Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust monetization frequency for wallets with low asset scale #145

Closed
1 task
raducristianpopa opened this issue Mar 7, 2024 · 1 comment · Fixed by #281
Closed
1 task

Adjust monetization frequency for wallets with low asset scale #145

raducristianpopa opened this issue Mar 7, 2024 · 1 comment · Fixed by #281
Assignees

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented Mar 7, 2024

Context

Wallets with a low asset scale (eg: USD - scale 2) cannot process payments with a higher asset scale (eg: we cannot send $0.0001 to a wallet address that has an asset scale of 2). The rate of pay slider supports values between between $0 and $1. The default rate of pay is $0.60/hour, resulting in $0.0000167/second. Therefore, the monetization frequency (how often an outgoing payment is created) needs to be adjusted and only send the smallest possible unit of that scale (2 or 1, depending on @interledger/pay - not one of our dependencies - this is the library that is creating the +-1 issue when creating an outgoing payment, used in Rafiki).

Impact: An use-case example of this impact - To prevent overpaying each time a website gets refreshed, when a refresh happens, the extension must check the timestamp of the most recent payment for each valid wallet address on the page to calculate if, how much, and when next to pay the wallet address.

Todos

  • Re-calculate the monetization frequency if we cannot send the monetization amount and only send the smallest possible unit of that scale
@tselit
Copy link

tselit commented May 28, 2024

This issue is partly blocked by an OP issue that impacts the ability to do a cross-currency fund transfer.

Had raised an issue with the OP team as there was incorrect behaviour when sending money between wallets that use the same asset code, but with wallets that use different asset scales.

  • still need to test again following the above issue resolved by the OP team
  • there's also a dependency on an issue raised with the Fynbos team where we need to test the alpha release when sending/receiving from a Test Wallet account to a Fynbos Wallet account (which we will potentially open as a separate ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants