Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the balance be persisted? #478

Closed
kincaidoneil opened this issue Jan 6, 2019 · 1 comment
Closed

Should the balance be persisted? #478

kincaidoneil opened this issue Jan 6, 2019 · 1 comment

Comments

@kincaidoneil
Copy link
Member

It appears the balance middleware always starts with an initial balance of 0, and doesn't persist it to the store.

If the connector mistakenly goes down, this is bad, because clients/peers would lose any credit they have. Additionally, the connector balance would become out-of-sync with those peers.
@matdehaast
Copy link

@kincaidoneil can we close this issue?

@kincaidoneil kincaidoneil mentioned this issue Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kincaidoneil @matdehaast