Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Remove ilp-core #76

Closed
emschwartz opened this issue Dec 29, 2016 · 1 comment
Closed

Proposal: Remove ilp-core #76

emschwartz opened this issue Dec 29, 2016 · 1 comment
Assignees

Comments

@emschwartz
Copy link
Contributor

Right now ilp-core implements two primary functions: quoting and managing multiple clients. These are relatively minimal bits of functionality but as a result of the current structure, ilp-core has to wrap and re-expose all of the plugin methods and events. This provides little value and makes the stack unnecessarily complicated.

For quoting, right now it seems that the ilp client and the ilp-connector use different methods for quoting and generating the source transfers. If the behavior is different for a reason, this suggests that quoting is not really shared functionality and thus should be implemented separately by the ilp and ilp-connector modules.

Regarding managing multiple clients, this functionality is not currently used by the ilp client and I don't think we need to support a multi-plugin sender any time in the near future. Again, the actual functionality provided by the core class of this module is pretty minimal, so it doesn't seem worth it to have another wrapper layer around the plugin.

I would propose that we move the quoting functionality from ilp-core into the ilp module, potentially exported separately as ILP.ILQP, move the multi-plugin functionality into the ilp-connector, and get rid of this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants