Global subscriptions #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.73% (diff: 95.67%)@@ master #88 diff @@
==========================================
Files 8 11 +3
Lines 590 627 +37
Methods 66 65 -1
Messages 0 0
Branches 141 146 +5
==========================================
+ Hits 563 594 +31
- Misses 27 33 +6
Partials 0 0
|
justmoon
force-pushed
the
feat/st-global-subscription
branch
from
2ccd308
to
8d4f07b
Compare
| const eventType = eventParams[0] | ||
| const eventAdditionalParams = eventParams.slice(1) | ||
| const accountIlpAddress = this.ledgerContext.prefix + this.ledgerContext.accountUriToName(account) | ||
| const eventGlobalParams = [eventType].concat([accountIlpAddress], eventAdditionalParams) |
There was a problem hiding this comment.
Couldn't this be const eventGlobalParams = [eventType, accountIlpAddress].concat(eventAdditionalParams)?
There was a problem hiding this comment.
Good call! Will change!
justmoon
force-pushed
the
feat/st-global-subscription
branch
from
8d4f07b
to
ebb525a
Compare
sentientwaffle
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the ability for ILP Kit to subscribe to all accounts on a ledger simultaneously, so we can skip the SPSP setup stage (using the Shared Secret Protocol transport) and react to incoming payments without prior warning.