perf: don't copy envelope contents

interledgerjs · Nov 1, 2018 · 1df2422 · 1df2422
1 parent 56cc86f
commit 1df2422
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/ilp-packet/index.ts b/packages/ilp-packet/index.ts
@@ -31,7 +31,7 @@ export const errorToReject = (address: string, error: IlpErrorClass) => {
   })
 }
 
-export const serializeEnvelope = (type: number, contents: Buffer) => {
+export const serializeEnvelope = (type: number, contents: Writer) => {
   const writer = new Writer()
   writer.writeUInt8(type)
   writer.writeVarOctetString(contents)
@@ -77,7 +77,7 @@ export const serializeIlpPrepare = (json: IlpPrepare) => {
   writer.writeVarOctetString(Buffer.from(json.destination, 'ascii'))
   writer.writeVarOctetString(json.data)
 
-  return serializeEnvelope(Type.TYPE_ILP_PREPARE, writer.getBuffer())
+  return serializeEnvelope(Type.TYPE_ILP_PREPARE, writer)
 }
 
 export const deserializeIlpPrepare = (binary: Buffer): IlpPrepare => {
@@ -119,7 +119,7 @@ export const serializeIlpFulfill = (json: IlpFulfill) => {
   writer.write(json.fulfillment)
   writer.writeVarOctetString(json.data)
 
-  return serializeEnvelope(Type.TYPE_ILP_FULFILL, writer.getBuffer())
+  return serializeEnvelope(Type.TYPE_ILP_FULFILL, writer)
 }
 
 export const deserializeIlpFulfill = (binary: Buffer): IlpFulfill => {
@@ -167,7 +167,7 @@ export const serializeIlpReject = (json: IlpReject) => {
   writer.writeVarOctetString(Buffer.from(json.message, 'utf8'))
   writer.writeVarOctetString(json.data || Buffer.alloc(0))
 
-  return serializeEnvelope(Type.TYPE_ILP_REJECT, writer.getBuffer())
+  return serializeEnvelope(Type.TYPE_ILP_REJECT, writer)
 }
 
 export const deserializeIlpReject = (binary: Buffer): IlpReject => {

diff --git a/packages/ilp-packet/package-lock.json b/packages/ilp-packet/package-lock.json
diff --git a/packages/ilp-packet/package.json b/packages/ilp-packet/package.json
@@ -52,6 +52,6 @@
   "dependencies": {
     "extensible-error": "^1.0.2",
     "long": "^4.0.0",
-    "oer-utils": "^3.1.1"
+    "oer-utils": "^3.2.0"
   }
 }