Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using ngl instead of pv #19

Open
heralden opened this issue Feb 25, 2020 · 2 comments
Open

Consider using ngl instead of pv #19

heralden opened this issue Feb 25, 2020 · 2 comments

Comments

@heralden
Copy link
Member

heralden commented Feb 25, 2020

I don't remember if we chose pv over ngl for some specific reason, or we didn't know about ngl.

https://github.com/arose/ngl

NGL seems to be actively developed as opposed to abandoned (which pv is) and is used by RCSB. It uses the standard coloring scheme for secondary structure, and also shows a tooltip when hovering over the strands. I subjectively think the models look prettier as well. [=

If it's not too much work, we might swap out pv for ngl.

Here's a comparison between pv and ngl, respectively, using secondary structure coloring of 5VPZ.

2020-02-25-102531_340x368_scrot
2020-02-25-102526_448x392_scrot

@anu-shree
Copy link

I want to work on this issue. Please assign this to me.

@heralden
Copy link
Member Author

@anu-shree Please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants