Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating bluegenes tool API to allow subclasses to show widgets #459

Closed
yochannah opened this issue Jan 9, 2020 · 1 comment · Fixed by #568
Closed

Support updating bluegenes tool API to allow subclasses to show widgets #459

yochannah opened this issue Jan 9, 2020 · 1 comment · Fixed by #568

Comments

@yochannah
Copy link
Member

Concrete example:

YeastMine child classes for Gene are the primary way to see gene info - for example, ORFs should display gene widgets. See a screenshot of the model below - ideally all sub-classes of gene should be able to show Gene-ready widgets. This is probably true for other aspects of the model as well.

image

@heralden heralden added this to To do in Production Roadmap via automation Jun 8, 2020
@heralden heralden moved this from To do to Discussion/Triage in Production Roadmap Jun 8, 2020
@heralden
Copy link
Member

heralden commented Jun 15, 2020

This equates to always accepting the "ORF" class, and focusing on subclasses of it.

We will probably need to look deeper into this to find an optimal solution.

Update: I looked deeper and this will require building a hierarchy based on the extends keys in the model. This is already done in the data browser on the querybuilder page.

(reduce (fn [h [child {:keys [extends]}]]
                       (reduce #(derive %1 child %2) h (map keyword extends)))
                     (make-hierarchy) model)

We should save this hierarchy somewhere and recompute it when changing mines, (probably compute it when fetching model and save it in app-db, making sure it's not saved to localStorage) as it will be useful for tasks related to subclasses.

To solve this issue, we would use the hierarchy to ask whether ORF isa? Gene, where ORF can be any class from the report or results pages, and Gene can be any class specified in the tool's classes config.

@heralden heralden moved this from Discussion/Triage to To do in Production Roadmap Jun 15, 2020
@heralden heralden changed the title Support updating bluegenes tool API to allow subclass report pages to show widgets Support updating bluegenes tool API to allow subclasses to show widgets Jun 19, 2020
Production Roadmap automation moved this from To do to Done Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants