Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply fix to TemplateAction to im 4.0? #2052

Closed
sergiocontrino opened this issue Jun 26, 2019 · 5 comments
Closed

apply fix to TemplateAction to im 4.0? #2052

sergiocontrino opened this issue Jun 26, 2019 · 5 comments
Labels

Comments

@sergiocontrino
Copy link
Member

in release 4.0 a bug has been introduced and commit c1bd944
in dev fixes it.
it has been fixed for flymine in production, and the 'one of' constraint seems to be working fine there after the fix.

@julie-sullivan
Copy link
Member

julie-sullivan commented Jun 28, 2019

From @rachellyne


Take a look at this template, the one-of constraints do not work,

http://www.flymine.org/flymine/template.do?name=modENCODE_RNA_seq_Tissues

If you click on edit, the constraints do not render properly:

    <constraint path="Gene.rnaSeqResults.stage" code="A" editable="true" op="ONE OF">
      <value>[Ljava.lang.String;@253b011
      </value>
    </constraint>
    <constraint path="Gene.rnaSeqResults.expressionLevel" code="B" editable="true" op="ONE OF">
      <value>[Ljava.lang.String;@4724dd95
      </value>
    </constraint>

@julie-sullivan julie-sullivan added this to the InterMine 4.1.0 milestone Jun 28, 2019
@julie-sullivan
Copy link
Member

@sergiocontrino can you describe the bug that you fixed? What was the bad behaviour?

@julie-sullivan
Copy link
Member

See #2044

@sergiocontrino
Copy link
Member Author

the fix is in commit c1bd944, where the condition
String extraValue = extraValues == null ? null : extraValues[0];

has been substituted by the verbose

String extraValue; if (extraValues == null) { extraValue = ""; } else { extraValue = extraValues[0]; }

extravalues being null was giving en error.

@julie-sullivan
Copy link
Member

This is working in beta flymine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants