-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain option values throw errors #1
Comments
@astanciu Thanks for the bug report.
Does that work? |
It got lightMin of 50 to work, but it was extremely slow. I then tried lightMin at 80 and got the same error. |
There's really strange stuff going on. lightMin: 55, lightMax 77, for ex, work. Pretty much the same for the other values, certain ranges work |
Thanks, I think I have an idea what's going on. |
I'm going to write a test suite for this. |
@astanciu grab However, if a setting works once, it should work everytime. Also, it wont error out anymore. but you could get duplicate colors. |
Found the real issue... closing in favor of #2 |
@astanciu please try the latest |
Hi! I got the same error with |
@owickstrom Same exact error message?
|
This throws an error:
var pallet = DistinctColors({count:50, lightMin: 50})
TypeError: Reduce of empty array with no initial value
If lightMin is less than 50, it works. I also see it in other random places, for example if hueMin is 300.
The text was updated successfully, but these errors were encountered: