Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different repository locations in README and Wiki, but none can be reached #754

Closed
EdithBirrer1 opened this issue May 17, 2023 · 6 comments

Comments

@EdithBirrer1
Copy link

Describe the bug
The README.md of the project and the Wiki list two different repositories. Neither seems to be reachable from public.

To Reproduce

Use a Maven-Java project and add the Steps to reproduce the behavior:

  1. Add the repository to the pom.xml (see list below)
  2. Add the dependency to the pom.xml:
    <dependency>
       <groupId>de.fraunhofer.ids.messaging</groupId>
       <artifactId>broker</artifactId>
       <version>7.0.0</version>
    </dependency>
    
  3. try to build the project

The two repository locations:

  • Repo according to current README.md is

    <repository>
       <id>sovity-public</id>
       <url>https://pkgs.dev.azure.com/sovity/5bec6cbd-c80a-47ac-86ce-1deb26cee853/_packaging/artifact/maven/v1</url>
    </repository>
    

    This address (when entered into a browser) responds with the message {"Info":"Feed 'artifact' root of maven repository"}, but is then not able to serve the requested dependency.

  • Repo according to Wiki page 1 is

    <repository>
         <id>isst-nexus-public</id>
         <name>isst-public</name>
         <url>https://mvn.ids.isst.fraunhofer.de/nexus/repository/ids-public/</url>
    </repository>
    

    This address (when entered into a browser) tekes a while, but then does not respond. It does also not serve the requested repo.

Expected behavior

The dependency can be loaded into the project.

Where is the correct repository for the dependencies?

@EdithBirrer1 EdithBirrer1 changed the title Diferent repository locations, none can be reached Different repository locations in README and Wiki, but none can be reached May 17, 2023
@tmberthold
Copy link
Contributor

The second repo is definitely deprecated and will not provide version 7.0.0. we will look at the Azure repo.

@tmberthold
Copy link
Contributor

Hi, after a quick check, version 7.0.0 is downloadable from our Azure repo, maybe it was a temporary issue?

For a reference implementation, the pom.xml of the DataSpaceConnector (DSC) can also be viewed.

Downloaded artifcats from azure (7.0.0):
image

<repository>
    <id>sovity-public</id>
    <url>https://pkgs.dev.azure.com/sovity/5bec6cbd-c80a-47ac-86ce-1deb26cee853/_packaging/artifact/maven/v1</url>
</repository>
<dependency>
    <groupId>ids.messaging</groupId>
    <artifactId>broker</artifactId>
    <version>${ids-messaging-services.version}</version>
    ...

<ids-messaging-services.version>7.0.0</ids-messaging-services.version>

Link to the connector reference implementation:
https://github.com/International-Data-Spaces-Association/DataspaceConnector/blob/cff7d16598520f25d112988861eed1e29a307cb8/pom.xml#L638

I will update the wiki, if there are still problems, please let me know again.

@EdithBirrer1
Copy link
Author

Thanks! Trying your response, I found that not only the repositories are/were listed differently in Wiki and README, but also the dependency. The Wiki lists group id as <groupId>de.fraunhofer.ids.messaging</groupId>, the REAMDE has <groupId>ids.messaging</groupId>.

In my first trials, I hadn't noticed the difference and tried the Wiki groupId against both repos - which then did not work. So please also update the groupId in the Wiki.
Now I could download the dependency and can start working with it - thanks!

@tmberthold
Copy link
Contributor

Hello and thank you.
With documentation it behaves like with demo videos: They do not age well. - Has been updated.

@EdithBirrer1
Copy link
Author

There is more to it... the filters for the component scan in Getting Started also need to be adapted (omit "de.fraunhofer"). I don't know what else...

@tmberthold
Copy link
Contributor

Hello and thank you for the feedback again!
We have also adjusted this part as well.
If there is anything else, please just let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants