New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README add installation instructions #44
Conversation
I think that's a helpful addition. One can't expect that anyone is familiar with Python tooling. |
(You may notice a couple more commits. The problem is that I can't get the code blocks to render correctly even though I believe I use the correct markdown. Perhaps someone with merge permission can fix it if it still doesn't render correctly after merge.) |
I think this is helpful, but I think it might also make sense to mention that the tagged releases are available on https://pypi.org/project/archive-pdf-tools/ - which means people can run BTW: I have been working on making the read the docs version better, which is here: https://archive-pdf-tools.readthedocs.io/en/latest/ - it's basically a more comprehensive version of the readme (some of it is copy paste) I think having an installation chapter there would also be good. |
Sounds good. Would you like me to amend the PR or are you asking for opinions before you amend the PR?
Where can this be amended? Is it automatically generated from the |
Right, that's correct, that is in |
Add installation instructions
Fix link markup for rst
Ok, that's about it. Sorry for the many commits. I didn't know RST, thought it was similar to MD. But now it works. |
Thanks, mind if I squash the commits into one? |
Not at all, do what you want. 🙂 |
|
||
First install dependencies. For example, in Ubuntu:: | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason you are always leaving 2 lines empty? I think 1 should be quite sufficient...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can fix that up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason
When in Rome, do as the Romans do. 🙂 I looked at the first existing code block I found (under "Usage")
@@ -61,6 +61,50 @@ For JBIG2 compression: | |||
* `jbig2enc <https://github.com/agl/jbig2enc>`_ for JBIG2 compression (and PyMuPDF 1.19.0 or higher) | |||
|
|||
|
|||
Installation | |||
------------ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it makes sense to duplicate the whole section. I personally wouldn't do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not too bad, if anything, maybe the README ought to refer to the docs for specifics.
I've merged this to master, thanks |
#41 (comment)