Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Diff" view for reviewing editgroups #77

Closed
bnewbold opened this issue Apr 13, 2021 · 1 comment
Closed

"Diff" view for reviewing editgroups #77

bnewbold opened this issue Apr 13, 2021 · 1 comment

Comments

@bnewbold
Copy link
Member

To make reviewing some editgroups faster, would be nice to have a view that displays in "patch" format.

Implementation notes:

  • use TOML for the diff. Confirm that python TOML library sorts keys consistently
  • for updates, ensure that diff is against current version of entity, not just trusting the "previous revision" pointer. there is a bug in some cases with updating-an-edit which would hide changes
  • display entity creation as a link to TOML (?)
  • display deletions and redirects similar to how they are already in editgroup review
  • endpoint could be /editgroup/<ident>/diff
  • have anchors in page with entity name, so can link directly to, eg, /editgroup/<ident>/diff#release_<ident> (or #release_edit_<id>?). then, link to this from entity history list
@bnewbold
Copy link
Member Author

This shipped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant