Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatcat_tools should not import from fatcat_web #88

Closed
bnewbold opened this issue Dec 16, 2021 · 1 comment
Closed

fatcat_tools should not import from fatcat_web #88

bnewbold opened this issue Dec 16, 2021 · 1 comment

Comments

@bnewbold
Copy link
Member

In the current code architecture, importing from fatcat_web executes fatcat_web/__init__.py, which does a whole bunch of stuff, and prints status to stderr. This is kind of confusing! It would be better if fatcat_tools never imported from fatcat_web, and only did imports in the other direction.

Could work around this by moving or copying the relevant code (currently, just some search queries for container status) to fatcat_tools.

@bnewbold
Copy link
Member Author

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant