Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace YouTube embed with YouTube API integration #178

Closed
bfalling opened this issue Jun 6, 2019 · 0 comments · Fixed by #229
Closed

Replace YouTube embed with YouTube API integration #178

bfalling opened this issue Jun 6, 2019 · 0 comments · Fixed by #229
Assignees
Labels
Enhancement A request to extend/improve an existing feature
Projects

Comments

@bfalling
Copy link
Collaborator

bfalling commented Jun 6, 2019

Context

Our integration with YouTube’s player is currently very limited. We’re basically just using their default embed. We can respond a lot better by using their API.

Proposal & Constraints

Replace the basic embed with integration with their API, which will provide the following benefits:

Ability to detect when song’s end, in order to play next

Ability to detect when there is a problem with a video, so we can display alternate messaging

Keep in mind that YouTube restricts too heavy use of their API’s.

An example of an album with lots of broken YouTube id’s: https://archive.org/details/cd_dark-side-of-the-moon_pink-floyd/disc1/02.+Pink+Floyd+-+On+the+Run.flac

@iisa will help define sub-tickets

@bfalling bfalling added the Enhancement A request to extend/improve an existing feature label Jun 6, 2019
@bfalling bfalling added this to To do in 2019 Q2-Q4 Jun 6, 2019
@iisa iisa moved this from To do to In progress in 2019 Q2-Q4 Jun 14, 2019
@koderjoker koderjoker moved this from In progress to Code review in 2019 Q2-Q4 Jun 24, 2019
@iisa iisa closed this as completed in #229 Jul 11, 2019
2019 Q2-Q4 automation moved this from Code review to Done Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A request to extend/improve an existing feature
Projects
No open projects
2019 Q2-Q4
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants