Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to play audio #459

Open
agharshit08 opened this issue Mar 14, 2019 · 5 comments
Open

Unable to play audio #459

agharshit08 opened this issue Mar 14, 2019 · 5 comments
Labels
assistant Support Google Assistant platform bug Something isn't working help wanted Extra attention is needed

Comments

@agharshit08
Copy link

Assistant app failed to play audio when user gave response in the following order

  • Live Concerts

  • The Phil Lesh and Friends

  • Randomly
    After that it leaves the conversation too.

@hyzhak hyzhak added help wanted Extra attention is needed assistant Support Google Assistant platform bug Something isn't working labels Mar 14, 2019
@alphadose
Copy link

It worked for me

Screenshot from 2019-03-19 18-40-39
9 18-40-39.png

@yagyanshbhatia
Copy link
Contributor

yagyanshbhatia commented Mar 19, 2019

@alphadose Local version is working for me too, but I think @agharshit08 is talking about Archive's assistant.
I'm experiencing similar problems.
@hyzhak 78s, live concerts, and christmas music they all fail. see screenshot here, here and here

@alphadose
Copy link

@hyzhak @yagyanshbhatia This could be a possible reason for the errors:-

The Google Cloud Functions uses Node version 6.11.5 to deploy the application. There is a lot of async/await in the current codebase. The async/await syntax was available from Node 7.6 and its not available in version 6.11.5 used by Google.

So unless internet archive uses something like Babel to convert ES6 to ES5 before launching in production, this could be the possible error.

@Abhishek856
Copy link

i want to work on this issue.

@vedang14
Copy link

@hyzhak I would really like to work on this, and resolve and optimize the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assistant Support Google Assistant platform bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants