Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcntl module does not exist on Windows #164

Open
tari opened this issue Nov 2, 2021 · 0 comments
Open

fcntl module does not exist on Windows #164

tari opened this issue Nov 2, 2021 · 0 comments

Comments

@tari
Copy link

tari commented Nov 2, 2021

warcprox/writer.py imports fcntl to acquire an exclusive lock on files opened for writing, but this fails on Windows because the fcntl module is only available on Unix-like systems. It should either gracefully degrade to not use file locking if the module is not available, or use a portable library like portalocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant