Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support in pullnews #256

Closed
Julien-Elie opened this issue Jan 23, 2023 · 0 comments
Closed

Add TLS support in pullnews #256

Julien-Elie opened this issue Jan 23, 2023 · 0 comments
Assignees
@Julien-Elie
Labels
C: utilities Related to utilities enhancement New feature or request P: low Low priority
Milestone
2.7.1

Comments

@Julien-Elie
Copy link
Contributor

pullnews does not currently support TLS connections. An option to activate it for downstream servers may be useful. We can already configure a port for the downstream server (via -p or -s), but not implicit TLS. As Net::NNTP natively provides a function to activate it, it should be easy to support it in pullnews.

As for upstream servers, pullnews.marks could use the following syntax:

server[:port][_TLS] [username password]

so as to ask for implicit TLS and/or a different port.

Make sure that server is correctly parsed, as it may contain colons (if written as an IPv6 address).
We would had:

news.server.com:563_TLS
news.server.com:433
@Julien-Elie Julien-Elie added enhancement New feature or request C: utilities Related to utilities P: low Low priority labels Jan 23, 2023
@Julien-Elie Julien-Elie added this to the 2.7.1 milestone Jan 23, 2023
@Julien-Elie Julien-Elie self-assigned this Jan 23, 2023
Julien-Elie added a commit that referenced this issue Feb 18, 2023
@Julien-Elie
pullnews: Add implicit TLS and STARTTLS support
7f7347a 
Implicit and explicit TLS support can now be negotiated by pullnews for
connections to upstream servers configured in pullnews.marks, and to
the downstream server specified in the -s flag.

Also, a port can be specified for connections to upstream servers (it
was already possible for the downstream server).

close #256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julien-Elie Julien-Elie

Labels
C: utilities Related to utilities enhancement New feature or request P: low Low priority
Milestone
2.7.1
Development

No branches or pull requests
1 participant
@Julien-Elie