Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install dice downloads tests #385

Closed
johnHostetter opened this issue Jul 21, 2023 · 2 comments
Closed

pip install dice downloads tests #385

johnHostetter opened this issue Jul 21, 2023 · 2 comments

Comments

@johnHostetter
Copy link

Hello,

After executing pip install dice, DiCE's tests override my project's test folder.

Steps to reproduce:

  1. Make a project with a tests folder
  2. pip install dice
  3. Make two test files in tests, one that defines some function (e.g., make_example) and another that imports that function:
    from tests.rough.krs import make_example
  4. Run tests; see Exception: ModuleNotFoundError: No module named 'tests.rough'

It seems the tests are being installed through pip. Can this be fixed?

DiCE/setup.py

Line 32 in e9e7147

packages=setuptools.find_packages(exclude=['tests*']),

I think tests* may need to be changed to simply tests.

Thank you for your time.

@gaugup
Copy link
Collaborator

gaugup commented Jul 31, 2023

@johnHostetter, The PR #382 has not been released as yet. Shouldn't this PR fix the issue?

@johnHostetter
Copy link
Author

@johnHostetter, The PR #382 has not been released as yet. Shouldn't this PR fix the issue?

Yes, my apologies. I must have overlooked the pull request. Thank you so much for addressing this issue and for your great work in providing us with this library! I intend to use it in some upcoming research if all goes according to plan (with appropriate citations for this work, of course 😄).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants