Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature selection when no continuous features are available #6

Merged
merged 2 commits into from Jul 15, 2022
Merged

Fix feature selection when no continuous features are available #6

merged 2 commits into from Jul 15, 2022

Conversation

wmeints
Copy link
Contributor

@wmeints wmeints commented Jul 13, 2022

I've got a model that has no continuous features. When I use the GAM changer, it fails to initialize the GAM view in the middle of the screen. This PR fixes the behavior so it chooses a categorical feature if no continuous features are available in the dropdown.

wmeints and others added 2 commits July 13, 2022 15:27
Signed-off-by: Willem Meints <1550763+wmeints@users.noreply.github.com>
Signed-off-by: Jay Wang <jay@zijie.wang>
@xiaohk xiaohk self-requested a review July 15, 2022 03:59
Copy link
Collaborator

@xiaohk xiaohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I have never used GAM Changer with only categorical features. 😅

Thanks for the PR! I fixed some comments.

@xiaohk xiaohk merged commit 1705488 into interpretml:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants