Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenGL] Weird star glitches at some places #137

Closed
inguin opened this issue Aug 15, 2018 · 5 comments
Closed

[OpenGL] Weird star glitches at some places #137

inguin opened this issue Aug 15, 2018 · 5 comments

Comments

@inguin
Copy link
Contributor

inguin commented Aug 15, 2018

The OpenGL star rendering glitches in a few places. I can reliably reproduce it in a room a the beginning of level 2 (see this savegame):

  1. Open the door and walk slowly towards the window; the stars "zoom out" when crossing the doorstep.
  2. Walk closer to the window; at some point the stars disappear.
@Interrupt
Copy link
Owner

Oh weird, it looks like something is happening with one of the View matrices there.

@inguin
Copy link
Contributor Author

inguin commented Aug 15, 2018

All three coordinates of each star become very small at the point of the zoom, so there's probably a rounding issue somewhere. It works when using the screen coordinates of each point (sx/sy/0) instead of the 3D coordinates, but I'm not sure how g3_project_point() can do a better job than OpenGL.

The second issue is still a mystery.

@Interrupt
Copy link
Owner

Interesting find! For me the stars even disappear at some spots using the sx / sy coordinates. Switching back to the Software renderer in those spots shows the stars, so it's even stranger.

@Interrupt
Copy link
Owner

#142 fixes some star rendering issues, but they still disappear sometimes.

@donnierussellii
Copy link
Contributor

Disappearing stars fix in my PR #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants