Skip to content

Commit

Permalink
fix: repair 'npm run start:local' (#758, #760)
Browse files Browse the repository at this point in the history
Closes #758
  • Loading branch information
dhhyi committed Jul 2, 2021
1 parent 757c1eb commit 1a07855
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/integration.yml
Expand Up @@ -14,6 +14,7 @@ on:

env:
ICM_BASE_URL: http://pwa-review.northeurope.cloudapp.azure.com:8081
NODE_OPTIONS: --max_old_space_size=8192

jobs:
CancelPrevious:
Expand Down
6 changes: 3 additions & 3 deletions angular.json
Expand Up @@ -48,14 +48,11 @@
},
"configurations": {
"production": {
"optimization": true,
"outputHashing": "all",
"sourceMap": false,
"namedChunks": false,
"extractLicenses": true,
"vendorChunk": true,
"commonChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "bundle",
Expand Down Expand Up @@ -86,6 +83,9 @@
"ngswConfigPath": "ngsw-config.json"
},
"local": {
"optimization": false,
"sourceMap": true,
"buildOptimizer": false,
"tsConfig": "tsconfig.app-no-checks.json",
"budgets": [
{
Expand Down
2 changes: 1 addition & 1 deletion e2e/test-schematics.sh
Expand Up @@ -146,7 +146,7 @@ echo '<p>COMPONENT_OVERRIDES</p>' > src/app/pages/home/home-page.component.local

export NODE_OPTIONS=--max_old_space_size=8192

npm run build --configuration=local,production
npm run build --configuration=local

nohup bash -c "npm run serve &"
wget -q --wait 10 --tries 10 --retry-connrefused http://localhost:4200
Expand Down
2 changes: 1 addition & 1 deletion templates/webpack/webpack.custom.ts
Expand Up @@ -64,7 +64,7 @@ export default (config: Configuration, angularJsonConfig: CustomWebpackBrowserSc
}

// set production mode, service-worker, ngrx runtime checks
const production = configurations.includes('production');
const production = configurations.includes('production') || angularJsonConfig.buildOptimizer;
const serviceWorker = !!angularJsonConfig.serviceWorker;
const ngrxRuntimeChecks = !!process.env.TESTING || !production;
config.plugins.push(
Expand Down

0 comments on commit 1a07855

Please sign in to comment.