Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Favorite Icon spawns error with latest Vivaldi #1194

Closed
jometzner opened this issue Jun 24, 2022 · 2 comments · Fixed by #1199
Closed

Getting Favorite Icon spawns error with latest Vivaldi #1194

jometzner opened this issue Jun 24, 2022 · 2 comments · Fixed by #1199
Labels
bug:minor bug Something isn't working

Comments

@jometzner
Copy link
Collaborator

jometzner commented Jun 24, 2022

Actual Behavior

You see error like this in SSR process (std. out).

1 b2b SSR /favicon.ico
1 b2b RES 404 /favicon.ico - accept header mismatch 'image/avif,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8'
1 b2b GET /favicon.ico 404 9 - 2.755 ms
3 b2b SSR /favicon.ico
3 b2b RES 404 /favicon.ico - accept header mismatch 'image/avif,image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8'
3 b2b GET /favicon.ico 404 9 - 1.719 ms

NGinx process

172.20.0.1 - - [23/Jun/2022:13:13:46 +0000] "GET /favicon.ico HTTP/1.1" 404 9 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.125 Safari/537.36" "-" 0.007 "-"

Expected Behavior

1 b2b GET /assets/themes/b2b/img/favicon.ico 200 102134 - 2.250 ms

Steps to Reproduce the Bug

Steps to reproduce the behavior:

  1. Go to Homepage of your local docker compose based setup (we need both, ssr and nginx)
  2. Check the ssr process output

Environment Details

  • Desktop:
    • OS: Linux
    • Browser Vivaldi, 5.3.2679.58 (Stable channel) stable (64-bit)

AB#77676

@jometzner jometzner added bug Something isn't working bug:minor labels Jun 24, 2022
@jometzner
Copy link
Collaborator Author

The issue is very likely caused by a SSR handled GET request to the favicon resource. The browser does that when it doesn't find a <link rel="icon" type="image/x-icon" href="x/y/z/favicon.ico" /> in the document. Whatever is the reason for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:minor bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant