Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should skip generated classes #36

Closed
adaptun opened this issue Apr 8, 2016 · 6 comments
Closed

we should skip generated classes #36

adaptun opened this issue Apr 8, 2016 · 6 comments

Comments

@adaptun
Copy link
Contributor

adaptun commented Apr 8, 2016

reported by @iColdheart and @dmitry-zasypkin

@adaptun adaptun closed this as completed in f99cf19 Apr 8, 2016
@eduard93
Copy link
Contributor

eduard93 commented Apr 8, 2016

why?

@dmitry-zasypkin
Copy link

why not?) everybody do this...

@adaptun
Copy link
Contributor Author

adaptun commented Apr 8, 2016

@eduard93 do you need not to skip it?

@tiagogribeiro
Copy link

This was tested Implementation in Caché 2013.1.1? I have problems when project import in %SYS, and error triggered: %SourceControl.Git.Utils.1.INT(408) ERROR #1054: Invalid expression

@adaptun
Copy link
Contributor Author

adaptun commented Jul 4, 2016

@tiago-sistema please open a new issue in such cases. I did it this time -- #39

@isc-bspead
Copy link

Generated Classes should always be skipped for source control hooks as generated classes are artifacts which are created by some action performed on other configuration items already in source control. Since that generation could differ from version to version of the DB, putting generated items into source control is a mistake because:

  1. They will be overwritten when the source configuration items are recompiled
  2. They could be incompatible with newer versions of the DB
    A great example of this would be classes generated by a SOAP Service or Client. These shouldn't be added to source control but should be generated automatically when the main source for these interfaces are compiled.
    Sorry to be late to the party, but I wanted to clarify this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants