[Request] want to change the comment style from "#;" which is inserted by "Ctrl + Slash"

[isc-bsaviano]

Discussed in https://github.com/intersystems-community/vscode-objectscript/discussions/1349

^{Originally posted by seisuke24am April 18, 2024}
Both vscode-objectscript and Studio, when "Ctrl + Slash" is put in the editor window, the comment #; is inserted in the code.

IRIS Studio has the option that users can change this comment style from #; to anything as they like.

Currently vscode-objectscript extention does not have this option so they cannot change the comment delimiter style.
So I put this request to add new option to change the comment delimiters.

[isc-bsaviano]

@seisuke24am In the future, please post bug reports/feature requests as issues. I don't think this is possible. VS Code's language configuration allow for one comment token per language, per type (block or line).

@gjsjohnmurray Do you know if a way we could support this?

[gjsjohnmurray]

@isc-bsaviano I think we set it here

vscode-objectscript/src/languageConfiguration.ts

Line 12 in e4ddce9

lineComment: ["objectscript-class", "objectscript-int"].includes(lang) ? "//" : "#;",

So it ought to be possible to support a config setting that overrides what we return to VS Code.

[isc-bsaviano]

That's true, but the language configuration is only set once at activation.

[gjsjohnmurray]

So it could be a setting that we state requires a reload.

[gjsjohnmurray]

Or try a listener for the setting change, then dispose the previous setLanguageConfiguration object and set a new one?

[isc-bsaviano]

The second approach is the one I would use. I don't feel strongly about this feature, but I'll leave it open for people to comment.

[isc-rsingh]

@seisuke24am this is an interesting idea. I would like to see additional interest before committing to find the right way to implement this. I advise requesting upvotes with a post on the InterSystems developer community to gain support for your feature.

[seisuke24am]

Thank you @isc-bsaviano to move my post here. I got it, I'll put similar enhancements requests here in "Issues".

Great idea @isc-rsingh , I posted the article to developer community about this request.
https://community.intersystems.com/post/agree-or-disagree-change-comment-delimiters-vs-code-extension

[isc-bsaviano]

Given the comments on the DC post and the fact that this was reported on behalf of a customer, I'm going to implement it.