Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return type for getItems #146

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: return type for getItems #146

merged 1 commit into from
May 8, 2023

Conversation

ranseur92
Copy link
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes the getItems typescript return type to more appropriately match the request. Resolves: #145

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@casualmatt
Copy link
Collaborator

Hello @ranseur92,
Ty, for your PR, it looks pretty st8 forward. Can we proceed with revision and merge, or do you need to commit something else?

@casualmatt casualmatt self-assigned this May 8, 2023
@ranseur92
Copy link
Contributor Author

Nothing else is needed. can be processed :)

@Intevel Intevel self-requested a review May 8, 2023 13:18
Intevel
Intevel approved these changes May 8, 2023
View reviewed changes
Copy link
Owner

@Intevel Intevel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@Intevel Intevel requested a review from casualmatt May 8, 2023 13:19
@Intevel Intevel changed the title fix return type for getItems fix: return type for getItems May 8, 2023
casualmatt
casualmatt approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@casualmatt casualmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casualmatt casualmatt added the waiting for merge Approved, is waiting for merge. label May 8, 2023
@Intevel Intevel merged commit 3382318 into Intevel:main May 8, 2023
5 checks passed
@c4software
Copy link

Hi,

Is it possible to tag a new version with this fix?

Thanks a lot.

@Intevel
Copy link
Owner

Intevel commented May 10, 2023

I will today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intevel Intevel Intevel approved these changes

@casualmatt casualmatt casualmatt approved these changes

Assignees

@casualmatt casualmatt

Labels
waiting for merge Approved, is waiting for merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ranseur92 @casualmatt @c4software @Intevel @codiam