Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify audience and issuer to validate token claims against #182

Closed
quezlatch opened this issue Feb 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@quezlatch
Copy link

quezlatch commented Feb 22, 2024

Describe the feature you'd like
Hi!

Currently the audience is calculated from the app_client_id and the issuer comes from the openId config. It would be really helpful to specify the audience and issuer to validate the token claims instead. Making them additional parameters in the AzureAuthorizationCodeBearerBase setup would be perfect.

Additional context
The way our azure application registration is set up is quite customised and does not give the expected claims. This would allow us to account for this.

Many thanks!

@quezlatch quezlatch added the enhancement New feature or request label Feb 22, 2024
@JonasKs
Copy link
Member

JonasKs commented Feb 23, 2024

Hi! Unfortunately, since this is special behavior not defined in the RFCs, I cannot accept such a feature.
Security is my main concern, and changes like these can have unintended side effects.

If you're confident in your design, I would recommend forking the repo and implement it yourself. 😊

@JonasKs JonasKs closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants