Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Chat window scroll to top when done processing output #387

Closed
2 tasks done
zenangst opened this issue Nov 7, 2023 · 10 comments
Closed
2 tasks done

[Bug]: Chat window scroll to top when done processing output #387

zenangst opened this issue Nov 7, 2023 · 10 comments
Assignees
Labels
bug Something isn't working released stale

Comments

@zenangst
Copy link

zenangst commented Nov 7, 2023

Before Reporting

  • I have checked FAQ, and there is no solution to my issue
  • I have searched the existing issues, and there is no existing issue for my issue

What happened?

The scroll view goes to the top after the output has been processed.

How to reproduce the bug.

Simply open the chat, ask something and wait for the response.

Relevant log output

No response

macOS version

macOS Sonoma 14.1 (23B74)

Xcode version

Xcode 15.0.1 (15A507)

Copilot for Xcode version

0.26.0

Node version

v20.3.1

@zenangst zenangst added the bug Something isn't working label Nov 7, 2023
@intitni
Copy link
Owner

intitni commented Nov 7, 2023

Can you provide a screen recording?

@zenangst
Copy link
Author

zenangst commented Nov 7, 2023

Coming right up!

scroll-bug.mov

@intitni
Copy link
Owner

intitni commented Nov 8, 2023

I can't reproduce it, it's probably some SwiftUI art.

I noticed from the video that there was an animation when the chat panel tried to stick to the bottom, the animation never worked for me so I forgot to remove it. I think that may be the cause.

Please give this version a try https://github.com/intitni/CopilotForXcode/releases/download/0.25.0/Copilot.for.Xcode.temp.app.zip

@zenangst
Copy link
Author

zenangst commented Nov 8, 2023

@intitni tried the version that you attached.
That one doesn't scroll when I use the keyboard shortcut to have it explain code.

scroll-bug-2.mov

It does however keep being stuck at the bottom if I manually scroll down and run the command again. But never with a fresh window.

Here are my settings for CoPilot for Xcode.

image

@zenangst
Copy link
Author

zenangst commented Nov 8, 2023

Seems like a timing issue 🤔
Because if I close the window and open it again using the keyboard command, it will work, like 1 out of 5 times or so.

@intitni
Copy link
Owner

intitni commented Nov 8, 2023

The behavior in the video is expected. When the scroll to bottom button at the bottom right is displayed, the chat panel will not stick to the bottom.

I should update it to re-enable stick to the bottom when a new message is sent.

But never with a fresh window.

Does the fresh chat start at the bottom?

@zenangst
Copy link
Author

zenangst commented Nov 8, 2023

It sometimes sticks to the bottom, other times it just keeps the current scroll location.

@zenangst
Copy link
Author

zenangst commented Nov 8, 2023

At least the version you attached doesn't seem to jump to the top when it is done processing, which is a good thing.

@intitni intitni added pending release Finished, but not yet released released and removed pending release Finished, but not yet released labels Nov 9, 2023
@intitni
Copy link
Owner

intitni commented Nov 9, 2023

Released in 0.27.0

Copy link

This issue is stale because it has been open for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released stale
Projects
None yet
Development

No branches or pull requests

2 participants