Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS build error #390

Closed
bobohuochai opened this issue Mar 10, 2021 · 2 comments · Fixed by #422
Closed

TS build error #390

bobohuochai opened this issue Mar 10, 2021 · 2 comments · Fixed by #422
Labels
good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request

Comments

@bobohuochai
Copy link

  • vue: 3.0.7
  • vue-i18n: 9.0.0

Screenshots
lerna ERR! yarn run build stdout:
$ tsc -b .
../../node_modules/@intlify/core-base/dist/core-base.d.ts(526,26): error TS2430: Interface 'SpecificDateTimeFormatOptions' incorrectly extends interface 'DateTimeFormatOptions'.
Types of property 'localeMatcher' are incompatible.
Type '"lookup" | "best-fit" | undefined' is not assignable to type '"lookup" | "best fit" | undefined'.
Type '"best-fit"' is not assignable to type '"lookup" | "best fit" | undefined'.
@bobohuochai bobohuochai added the Status: Review Needed Request for review comments label Mar 10, 2021
@kazupon
Copy link
Member

kazupon commented Mar 11, 2021

Thank you for your reporting!

I recoganize that the I/F of localeMatcher has changed in TS4.2.
I’m going to fix this in the vue-i18n v9.1 release.

@kazupon kazupon added Status: In Progress Work in Progress good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request and removed Status: Review Needed Request for review comments Status: In Progress Work in Progress labels Mar 11, 2021
@kazupon kazupon mentioned this issue Mar 24, 2021
Closed
@kazupon kazupon closed this as completed Apr 1, 2021
@kazupon
Copy link
Member

kazupon commented Apr 1, 2021

Fixed with #417

@kazupon kazupon mentioned this issue Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Status: PR Welcome Welcome to Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Intl type definition for TS 4.2 intlify/vue-i18n
2 participants
@kazupon @bobohuochai