Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defineComputed inside t, d and other composer methods is not needed #72

Closed
Demivan opened this issue Jul 9, 2020 · 0 comments · Fixed by #81
Closed

defineComputed inside t, d and other composer methods is not needed #72

Demivan opened this issue Jul 9, 2020 · 0 comments · Fixed by #81

Comments

@Demivan
Copy link
Contributor

Demivan commented Jul 9, 2020

Looks like defineComputed call is not needed because computed is immediately unwrapped and only primitive string value is returned.
https://github.com/intlify/vue-i18n-next/blob/d0ed0a5b9924ce000d630e9f11ea00c608ff81fb/src/composer.ts#L505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove computed wrapping intlify/vue-i18n
1 participant
@Demivan