Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flat json separated with dot('.') #294

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

PeterAlfredLee
Copy link
Member

This is an implemention for #271.

With handleFlatJson, we can recrusively search the object for keys containing dot('.'), and transform the flat structure to normal structure so we can handle them as before.

The corresponding tests are also included.

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Jan 16, 2021
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
This is great works!
LGTM!

@PeterAlfredLee
Copy link
Member Author

I'm glad this helps a little bit. :-)

@PeterAlfredLee PeterAlfredLee deleted the supportFlatJson branch January 18, 2021 06:09
@tangjinzhou
Copy link

This is a break change. we should support configurable. And not enabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants