Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: factory improvements #6

Merged
merged 3 commits into from
Apr 8, 2020
Merged

breaking: factory improvements #6

merged 3 commits into from
Apr 8, 2020

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Apr 8, 2020

  • rename to Composer from I18nComposer
  • organize factory function in one
    • createI18n({ ... }) -> createI18n({ legacy: true, ... })
    • createI18nComposer({ ... }) -> createI18n({ ... })

@kazupon
breaking: rename to Composer from I18nComposer
b139f43
@kazupon
breaking: organize factory function in one
ea84ac5 
NOTE:
  createI18n({ ... }) -> createI18n({ legacy: true, ... })
  createI18nComposer({ ... }) -> createI18n({ ... })
@kazupon
update examples
9d28769
@kazupon kazupon added the Type: Breaking Includes backwards-incompatible fixes label Apr 8, 2020
@kazupon kazupon merged commit 4974f48 into master Apr 8, 2020
@kazupon kazupon deleted the improve/factory branch April 8, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Breaking Includes backwards-incompatible fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kazupon