-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a check to verify that all QR codes were found (none are skipped) #11
Comments
Good idea. We tried to keep the restore code very simplistic so that it can easily be ported to other systems (think restoring an old backup several years in the future). I think to implement it we'd have to break the pipe in paperrestore after the sort, store the sorted results of zbarimg in a tempfile and then check the contents (compare wc -l vs. the barcode number in the last line). Or do you see a way to do it without a tempfile? |
One idea would be to use |
Here a POC:
|
i agree with @intra2net that the restore code should be simple, or at least that there should be a simple version of it, ideally printed alongside the document (#16). that said, if we're going to add awk to the already complex and difficult to read pipeline here, i think we'd be better serve by adding a restore option to the python program itself, keeping a fallback copy as a shell script. |
Even with a perfect QR code it could happen that
zbarimg
fails to detect it (mchehab/zbar#65). Since the codes are numbered it would be nice ifpaperrestore.sh
contains a check whether there is no gap in the sequence.The text was updated successfully, but these errors were encountered: