Coerce improvements #96
Conversation
In `Hashie::Mash`, implement `#[]` and `#[]=` as `#custom_reader` and `#custom_writer`, respectively, so they can be called explicitly (aliases provided for backward compatibility). The `#deep_update` method now uses the custom reader/writer methods, instead of the regular reader/writer methods (which bypass coercion). In `Coercion`, override `#custom_writer` to use the coercing setter method. Additionally, force `.to_sym` on keys passed to `#key_coercion`, to allow the string keys used by `Hashie::Mash` to work. These together allow coercion to work with `Hashie::Mash` instances, not only with direct `mash[:key]` symbolic indexing, but with `mash.key` attribute style, `mash['key']` string indexing, and `Mash.new(:key => ...)` instance initialization. All spec tests are passing now.
|
Why did you choose to add alias |
|
I tried using |
|
@mbleigh any thoughts on this? |
|
I originally abandoned implementing Mash et al because of infinite recursion problems, so it definitely happens. I don't think I have a problem with this if specs are passing. |
|
Thanks for merging. If this needs revisiting sometime down the road, let me know--I admit this was kind of a hasty patch. |
Adjustments to make Coercion work better with Mash, per issue #95.