Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept options as default arg values #701

Merged
merged 1 commit into from Sep 30, 2013
Merged

accept options as default arg values #701

merged 1 commit into from Sep 30, 2013

Conversation

lanej
Copy link
Contributor

@lanej lanej commented Sep 29, 2013

  • prevents empty args from nulling out valid option values

@lanej
accept options as default arg values
926095f 
* prevents empty args from nulling out valid option values
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 926095f on lanej:default_args into 83284ce on intridea:master.

@tmilewski
Copy link
Member

Thanks again @lanej!

tmilewski pushed a commit that referenced this pull request Sep 30, 2013
Merge pull request #701 from lanej/default_args
b19cfe4 
accept options as default arg values - prevents empty args from nulling out valid option values
@tmilewski tmilewski merged commit b19cfe4 into omniauth:master Sep 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lanej @coveralls @tmilewski