Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check prCommit.author is defined. #14

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Check prCommit.author is defined. #14

merged 1 commit into from
Dec 6, 2018

Conversation

adierkens
Copy link
Collaborator

What Changed

Checking for prCommit.author being null/undefined before trying to get the corresponding username

Why

Cause bugs

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@adierkens adierkens added bug Something isn't working patch labels Dec 6, 2018
@adierkens adierkens changed the title Check for undef prUser.login Check prCommit.author is defined. Dec 6, 2018
@adierkens adierkens closed this Dec 6, 2018
@adierkens adierkens reopened this Dec 6, 2018
@hipstersmoothie hipstersmoothie merged commit 5ef4591 into intuit:master Dec 6, 2018
@hipstersmoothie
Copy link
Collaborator

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adierkens @hipstersmoothie