Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git user options #37

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Add git user options #37

merged 1 commit into from
Dec 8, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Dec 8, 2018

What Changed

Get git user from cli args, config, or package.json.

Why

Previously auto would fail when no git user was set.

closes #34

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #37 into master will decrease coverage by 0.05%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   79.12%   79.06%   -0.06%     
==========================================
  Files          12       12              
  Lines         800      817      +17     
  Branches      104      100       -4     
==========================================
+ Hits          633      646      +13     
- Misses        150      152       +2     
- Partials       17       19       +2
Impacted Files Coverage Δ
src/github-release.ts 94.66% <ø> (ø) ⬆️
src/cli/args.ts 100% <100%> (ø) ⬆️
src/main.ts 24.08% <66.66%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af67937...5c00141. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 09361e4 into master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto configure username and email
1 participant