Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to skip canaries on skip releases #962

Closed
zephraph opened this issue Feb 19, 2020 · 3 comments · Fixed by #993
Closed

Add the ability to skip canaries on skip releases #962

zephraph opened this issue Feb 19, 2020 · 3 comments · Fixed by #993
Labels
enhancement New feature or request released This issue/pull request has been released.

Comments

@zephraph
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Talked to @hipstersmoothie about this on twitter, but I wanted to document it for good measure. Currently running auto canary in CI will always produce a canary, regardless of what labels are on a PR. For cases where we don't intend to ship a release (especially with documentation or dependency updates) it'd make sense to avoid generating canaries.

Describe the solution you'd like

Add a mechanism to skip releases to auto canary. It could be an explicit argument added to the canary command to check labels or some other mechanism.

Describe alternatives you've considered

We could choose not to solve this and instead push it to user land for them to decide how best to run or not run auto canary based off of whatever conditions they have. We do already have auto label which does help a bit.

@zephraph zephraph added the enhancement New feature or request label Feb 19, 2020
@adierkens
Copy link
Collaborator

Would using the existing labels on a PR help with this? If documentation or dep-update labels are mapped to a not generate a release, auto canary also won’t produce one.

Can also use a —force flag to force it to create a release, or maybe a way to ignore labels supplying your own semver bump.

@zephraph
Copy link
Collaborator Author

Yep, I like that idea. It’s somewhat breaking to how it currently functions, but more in line with what I’d expect.

@adierkens
Copy link
Collaborator

🚀 Issue was released in v9.15.4 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants