Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key.ENTER for chrome native not working properly #1192

Closed
ptrthomas opened this issue Jun 26, 2020 · 1 comment
Closed

Key.ENTER for chrome native not working properly #1192

ptrthomas opened this issue Jun 26, 2020 · 1 comment
Assignees
@ptrthomas
Labels
bug fixed

Comments

@ptrthomas
Copy link
Member

been reported - but is more serious than initially thought: #1169

stack overflow: https://stackoverflow.com/q/62596932/143475
@ptrthomas ptrthomas added the bug label Jun 26, 2020
@ptrthomas ptrthomas added this to the 0.9.6 milestone Jun 26, 2020
@ptrthomas ptrthomas self-assigned this Jun 26, 2020
ptrthomas added a commit that referenced this issue Jun 27, 2020
@ptrthomas
this finally fixes enter key on chrome native #1192
9b07304 
there were 2 problems - we had a typo in [modifiers] key sending to cdt but that was not the reason
turns out chrome honors only carriage-return not line-feed
hint for others who come across this in future - when you use chromedriver and use the --verbose flag
you can see all chrome dev-tools websocket traffic, which is very useful :)
@ptrthomas ptrthomas mentioned this issue Jun 27, 2020
Closed
ptrthomas added a commit that referenced this issue Jun 30, 2020
@ptrthomas
adjustment to handle dot / period for chrome native #1192
08aa9bd
@yourfrienddhruv
Copy link

Thanks @ptrthomas ! This fix brings huge stability on our flaky tests, We had all these symptoms #1169 (comment) and till now have to use aggregated multiple runs positives result status. Thanks @dialex .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrthomas ptrthomas

Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptrthomas @yourfrienddhruv