Please set default socket timeout for ApacheHttpClient

[leozilla]

Looking into ApacheHttpClient only the following timeout options are set:

clientBuilder.setDefaultRequestConfig(configBuilder.build());

This has as a consequence that HTTPS requests can hang forever during the HTTPS handshake!
The stack trace can be seen in this ticket and I had the same problem today which I could easily reproduce with our auth service which does not finish the HTTPS handshake for whatever reason.

To fix this, just set a default socket config and specify the SoTimeout

// getSocketTimeout does not exist yet and should be added    
this.clientBuilder.setDefaultSocketConfig(SocketConfig.custom().setSoTimeout(config.getSocketTimeout()).build()); 

[leozilla]

Btw: I would like to provide a PR but mvn clean install does not work for me without fixing a ton of errors. I have to say this is really annoying and prevents from contributing to this otherwise very fine project.

[ptrthomas]

@leozilla sorry to hear that. perhaps you can start with contributing solutions to the "ton of errors" you are seeing

[leozilla]

@ptrthomas does mvn clean install work for you? if yes, what java version, what maven version and what OS are you using?

[ptrthomas]

@leozilla yes

$ mvn --version
Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T13:28:13+05:30)
Maven home: /Users/somebody/dev/apache-maven
Java version: 1.8.0_112, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"

[jlee70]

latest builds fine for me too.
$ mvn --version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T08:41:47-08:00)
Maven home: /usr/local/apache-maven/apache-maven-3.3.9
Java version: 1.8.0_121, vendor: Oracle Corporation
Java home: /Users/somebody/.sdkman/candidates/java/8u121/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"

[ptrthomas]

nevermind, just attempted fix

[ptrthomas]

0.9.0 released