Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split karate-ui into new maven / JAR module moving javafx out of karate-core #780

Closed
ptrthomas opened this issue May 18, 2019 · 6 comments
Closed
Assignees
Milestone

Comments

@ptrthomas
Copy link
Member

definitely causing projects to break that use spring / spring boot:

https://stackoverflow.com/q/56193195/143475
https://stackoverflow.com/a/56059478/143475

this will be a breaking change :| better to do this sooner instead of waiting for 1.0.0

@ptrthomas ptrthomas added this to the 0.9.3 milestone May 18, 2019
@ptrthomas ptrthomas self-assigned this May 18, 2019
ptrthomas added a commit that referenced this issue May 18, 2019
the prev commit moved ui package into the netty module
this commit introduces the new karate-ui maven module
we no longer publish the karate-netty artifact
there seems to be some issues with javafx system wide conflicts when running the fat jar
@cpressler
Copy link

here is my comments from an issue I ran into

https://stackoverflow.com/questions/8861485/contextload-error-in-spring

@ptrthomas
Copy link
Member Author

@cpressler can you try now with 0.9.3.RC2 ?

@cpressler
Copy link

0.9.3.RC2 now works for the minimal spring boot test contextLoads(). Thanks!

import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.junit4.SpringRunner;

@RunWith(SpringRunner.class)
@SpringBootTest
public class JugToursApplicationTests {
@test
public void contextLoads() {
}

}

@cpressler
Copy link

FYI adding this dependency now seems to cause a failure but I do not need it so I am good for now.

com.intuit.karate
karate-ui
${karate.version}
test

@ptrthomas
Copy link
Member Author

@cpressler you can always use a maven profile to use it in dev mode but not mess up your CI

@ptrthomas
Copy link
Member Author

released 0.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants