Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports doesn't log requests when call a feature using javascript #965

Closed
sromeu-ob opened this issue Nov 12, 2019 · 5 comments
Closed

Reports doesn't log requests when call a feature using javascript #965

sromeu-ob opened this issue Nov 12, 2019 · 5 comments
Assignees

Comments

@sromeu-ob
Copy link

HI,

I realised that when you call a feature file or an specific scenario using a javascript function, all requests made in the called feature are not logged to the html reports.

On the other hand, if I call a feature file or scenario using the "call read" step,, it works fine and all requests are printed in the report.

Peter, I have updated the previous sample project in order to create a flow that make sense.

Thanks!

karate-basic.zip

@ptrthomas
Copy link
Member

ptrthomas commented Nov 13, 2019

@sromeu-ob I'm marking this is a won't fix, because there is a limit to what we support and I still don't understand the weird nesting you are trying. I'll like your help to identify what is and what isn't possible. and if you want you can create a PR for the readme

personally I highly discourage nested calls, especially JS. if you want some history and a related discussion, and WHY - see this: #722

and finally if you can contribute a fix, nothing like it :)

@sormuras
Copy link
Contributor

👍 😉

@ptrthomas
Copy link
Member

sorry @sormuras I tagged you by mistake and then edited :)

@ptrthomas ptrthomas self-assigned this May 20, 2020
@ptrthomas ptrthomas added this to the 0.9.6 milestone May 20, 2020
@ptrthomas ptrthomas reopened this May 21, 2020
ptrthomas added a commit that referenced this issue May 21, 2020
this was pending for a long time and I think with a thread-local approach it is done
also made embedding more fool-proof especially in driver / robot call edge cases
@ptrthomas
Copy link
Member

@sromeu-ob if you have time can you test that the fix in the develop branch works fine ? https://github.com/intuit/karate/wiki/Developer-Guide

@ptrthomas
Copy link
Member

0.9.6 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants