Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Legacy and Modern Theme Generation #20

Open
tylerkrupicka opened this issue Sep 30, 2020 · 0 comments
Open

Refactor Legacy and Modern Theme Generation #20

tylerkrupicka opened this issue Sep 30, 2020 · 0 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@tylerkrupicka
Copy link
Contributor

When we started this project we had to support IE11 which influenced what is now the "legacy" implementation of theme generation. When we dropped IE support we switched to the modern style.

These generators currently live in the same file and tend to have large individual functions, where some logic could probably be broken out.

If you're interested, I'd be happy to review a pull request to split out the implementations into separate files and clean up some of the functions and comments.

Make sure all of the tests still pass!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tylerkrupicka