Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gov-Client-Public-IP-Timestamp header to HMRC headers #126

Closed
skodamarthi opened this issue Sep 25, 2021 · 4 comments
Closed

Add Gov-Client-Public-IP-Timestamp header to HMRC headers #126

skodamarthi opened this issue Sep 25, 2021 · 4 comments
Labels

Comments

@skodamarthi
Copy link
Contributor

skodamarthi commented Sep 25, 2021

Is your feature request related to a problem? Please describe.
Refer to HMRC documentation here to know the info we need to send as part of this header: https://developer.service.hmrc.gov.uk/guides/fraud-prevention/connection-method/web-app-via-server/#gov-client-public-ip-timestamp

Describe the solution you'd like
Add a function to fetch timestamp when public IP address is collected using https://api.ipify.org as part of Gov-Client-Public-IP header and use that function to generate Gov-Client-Public-IP-Timestamp header needed by HMRC for fraud prevention.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@skodamarthi skodamarthi added enhancement New feature or request good first issue Good for newcomers GraceHopperOSD labels Sep 25, 2021
@RiyaJohn
Copy link
Contributor

RiyaJohn commented Oct 4, 2021

@skodamarthi can I work on this issue?

@reubenae
Copy link
Contributor

reubenae commented Oct 5, 2021

@RiyaJohn no need to ask, just go ahead and submit a PR

@RiyaJohn
Copy link
Contributor

RiyaJohn commented Oct 7, 2021

Cool, working on it, will raise a PR soon

@skodamarthi
Copy link
Contributor Author

We have decided to close this issue for now as introducing this header in the library could cause issues to the existing customers, and adding this header using 3rd party APIs felt more of an unnecessary overhead than a benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants