Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moment.js as a dependency #15

Closed
reubenae opened this issue Sep 10, 2020 · 3 comments
Closed

Remove moment.js as a dependency #15

reubenae opened this issue Sep 10, 2020 · 3 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@reubenae
Copy link
Contributor

Started this work here #6 as an example

We use a single function from moment's massive library. The benefit here is to reduce the bundle size; ideally by removing any dependency on moment.js

@honsq90
Copy link

honsq90 commented Sep 30, 2020

I can give this a go

@honsq90
Copy link

honsq90 commented Oct 1, 2020

seems like yarn.lock is expecting this as the registry url? https://registry.npmjs.intuit.com:443

this preventing me from installing/removing packages. not sure if I want to remove moment.js and update the yarn lockfile.

@reubenae
Copy link
Contributor Author

reubenae commented Oct 1, 2020

Thanks @honsq90 - we'll look into that issue. While you are very welcome to contribute a fix for this issue, there is already a PR which has gone through a few iterations open for this issue - #6 - you would probably be better off working on another issue so we're not duplicating effort. Would appreciate your review on that PR though, to see if you would have approached this issue differently. Thanks!

@reubenae reubenae closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants