fix: visibility of reqs::Order constructors #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where `pub(crate)` struct constructors wouldn't actually be exposed.
|
Merged, it was wrong decision to think that it not necessary to oneone. Will pub 0.4.1 now. |
|
Thank you for your help with the library. |
|
Thank you for the quick publishing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please forgive me if this isn't actually necessary. I believe that
pub(crate)is ambiguous on struct constructors and doesn't actually cause these functions to be exposed publicly.If I'm incorrect here, please excuse this PR and let me know the correct syntax to create a request using
marketorlimitconstructors from an external package.