Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NULL SQLSTATE with custom UnknownError type #120

Merged
merged 1 commit into from Aug 9, 2019
Merged

Support NULL SQLSTATE with custom UnknownError type #120

merged 1 commit into from Aug 9, 2019

Conversation

iamed2
Copy link
Owner

@iamed2 iamed2 commented Aug 8, 2019

Fixes #116

fchorney
fchorney approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@fchorney fchorney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

@iamed2 iamed2 merged commit 0cc952c into master Aug 9, 2019
@iamed2 iamed2 deleted the ed/null-sqlstate branch August 9, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchorney fchorney fchorney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'nothing' type union in error pathway not considered
2 participants
@iamed2 @fchorney