cli: initial implementation using Click #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| es-jsonschema provides a library and a CLI generating Elasticsearch mappings from json-schemas. | ||
|
|
||
| - CERN <info@invenio-software.org> |
nharraud
force-pushed
the
add-cli
branch
2 times, most recently
from
a67dc6c
to
74f1814
Compare
|
Good catch |
nharraud
force-pushed
the
add-cli
branch
4 times, most recently
from
7fb354e
to
5377e9f
Compare
|
@jirikuncar PR ready for review. Only invalid use cases remain untested. I can fix that in another PR. |
| resolver, config, | ||
| es_properties.get(prop)) | ||
| for prop, prop_schema in iteritems(json_schema['properties']): | ||
| es_properties[prop] = \ |
There was a problem hiding this comment.
it's preferable to break line after ( instead of introducing \.
28 tasks
| @@ -40,10 +46,48 @@ def __init__(self, *args, **kwargs): | |||
| } | |||
| # json string formats -> elasticsearch type | |||
| self.__formats_map = {} | |||
There was a problem hiding this comment.
be careful with using double underscore for properties (https://docs.python.org/2/tutorial/classes.html#private-variables-and-class-local-references) - they make it hard for subclassing ...
|
@jirikuncar Fixed and added an example |
| def test_schema_to_mapping(): | ||
| """Test schema_to_mapping.""" | ||
| json_schema = { | ||
| 'id': 'http://some.site/root_schema#', |
|
@jirikuncar squashed in one commit as requested. |
|
@nharraud please run |
* Fixes some issues. * Refactors es_jsonschema so that it can be used with a CLI. * Adds examples. Signed-off-by: Nicolas Harraudeau <nicolas.harraudeau@cern.ch>
|
@jirikuncar fixed and travis finished at last. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage is ok but not perfect (97%).