pkgresources: advanced entry points #30
pkgresources: advanced entry points #30
Conversation
entry_point.load() if self.load else entry_point | ||
) | ||
value = entry_point.load() if self.load else entry_point | ||
is_registered = entry_point.name in self.registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThiefMaster fixed
d29a987
to
0fb78db
Compare
0fb78db
to
3ea8c16
Compare
Hi, soon it will be one year since our last discussion about making Flask-Registry and Flask-PluginEngine to work together. Would this PR make it easier? What is it missing? |
IIRC what happened ~1yr ago, the agreement was that we need to sit down and figure out how feasible it would be to bring the two projects together, based on each project's own architecture and needs. We definitely want (and there's space for that in next year's draft plan for that) to spend some time improving and documenting It's clear that a joint effort would be the ideal scenario (and there's a lot of potential for a fruitful collaboration), but that can only come after we all have a good understanding of what each project is doing and what are the common needs/points. |
Pedro, I fully support your last paragraph, and would like to draw everyone's attention to the fact that I have tasked @jbenito3 with a short project to identify the areas of potential for common approaches, and shared codebases, so that we can efficiently plan next years developments in projects coherently |
3ea8c16
to
f57595e
Compare
5a1aede
to
532e96a
Compare
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
532e96a
to
14731f5
Compare
I have updated the PR so it passes the tests however we don't need dependency checking with our new architecture in Invenio 3. You check how we are loading extensions in Invenio-Base using entry points only. |
* Fixes doctests. (closes inveniosoftware-attic#21) Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
EntryPointRegistry
.cc @ThiefMaster @pferreir