Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable default values for arguments #114

Open
max-moser opened this issue Mar 10, 2023 · 3 comments · Fixed by #115
Open

Mutable default values for arguments #114

max-moser opened this issue Mar 10, 2023 · 3 comments · Fixed by #115
Labels
bug Something isn't working

Comments

@max-moser
Copy link
Contributor

Package version (if known): 1.0.0

Describe the bug

It looks like there's some mutable objects used as default values for some function arguments, e.g. a dictionary literal here.
Chances are that this is unintentional and basically a pitfall that I think every Python programmer has fallen into at some point.

Unless this is intended, we should change the default values for arguments to something non-mutable.

@max-moser
Copy link
Contributor Author

Thanks a lot! 👌

@ppanero
Copy link
Member

ppanero commented Mar 24, 2023

merged flask-resources, re-opening for the rest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants