Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Github-Actions #58

Closed
chriz-uniba opened this issue Oct 4, 2023 · 2 comments
Closed

Broken Github-Actions #58

chriz-uniba opened this issue Oct 4, 2023 · 2 comments
Labels

Comments

@chriz-uniba
Copy link

Package version (if known): Current master (2023-10-04)

Describe the bug

After making a minor change in the setup.cfg-file the github-actions do not run through. I think the error is not related to the changes that were made (see #57)

Tests (3.8, pypi)
failed Oct 4, 2023 in 48s

Run ./run-tests.sh
lists of files in version control and sdist match

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sphinx/config.py", line 332, in eval_config_file
    exec(code, namespace)
  File "/home/runner/work/flask-security-fork/flask-security-fork/docs/conf.py", line 18, in <module>
    from flask_security import __version__
  File "/home/runner/work/flask-security-fork/flask-security-fork/flask_security/__init__.py", line 29, in <module>
    from flask_login import login_required
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/flask_login/__init__.py", line 12, in <module>
    from .login_manager import LoginManager
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/flask_login/login_manager.py", line 33, in <module>
    from .utils import _create_identifier
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/flask_login/utils.py", line 14, in <module>
    from werkzeug.urls import url_decode
ImportError: cannot import name 'url_decode' from 'werkzeug.urls' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/werkzeug/urls.py)

Error: Process completed with exit code 2.

Expected behavior

github-actions should run through for the master-branch

@chriz-uniba chriz-uniba added the bug label Oct 4, 2023
@yashlamba
Copy link
Member

yashlamba commented Oct 5, 2023

Hey @chriz-uniba, this is related to dependency pinning. We didn't have an upper cap on Flask and Werkzeug versions, both of which released 3.x.x recently.

This probably will be fixed with #56

@chriz-uniba
Copy link
Author

yes - I rebased and the tests are happy now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants